feat: use modern Streams API by GrosSacASac · Pull Request #531 · node-formidable/formidable

GrosSacASac · 2019-12-09T11:45:58Z

No description provided.

lgtm-com · 2019-12-17T17:12:36Z

This pull request introduces 1 alert and fixes 2 when merging 2f9191d into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

end does not return errors, use 'error' event instead write does not return length anymore

lgtm-com · 2019-12-17T17:17:07Z

This pull request introduces 1 alert and fixes 2 when merging 214708a into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

lgtm-com · 2019-12-17T17:43:40Z

This pull request introduces 1 alert and fixes 2 when merging b688b66 into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

lgtm-com · 2019-12-17T18:45:52Z

This pull request introduces 1 alert and fixes 2 when merging 308dfa0 into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

GrosSacASac · 2019-12-18T10:13:31Z

removed a memory leak in the process

lgtm-com · 2019-12-18T21:56:17Z

This pull request introduces 1 alert and fixes 2 when merging c4f8d7b into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

lgtm-com · 2019-12-18T22:07:58Z

This pull request introduces 1 alert and fixes 2 when merging dd4a9d5 into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

lgtm-com · 2019-12-21T19:55:46Z

This pull request introduces 1 alert and fixes 2 when merging bf10f2f into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

lgtm-com · 2019-12-22T00:23:41Z

This pull request introduces 1 alert and fixes 2 when merging e9f226d into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

lgtm-com · 2019-12-26T17:56:20Z

This pull request introduces 1 alert and fixes 2 when merging 3f392e1 into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

lgtm-com · 2019-12-26T18:02:41Z

This pull request introduces 1 alert and fixes 2 when merging 40b830e into b04b5ac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable
1 for Unused variable, import, function or class

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

tunnckoCore · 2020-01-28T15:54:45Z

Btw, it's interesting why tests getting more time to pass than these in master?

Anyway, I'll merge it and continue.

tests are fricking nightmare...

lgtm-com · 2020-01-28T15:56:33Z

This pull request introduces 1 alert and fixes 1 when merging 3d0b96d into a26cdac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

lgtm-com · 2020-01-28T16:17:55Z

This pull request introduces 1 alert and fixes 1 when merging 0bd03a1 into a26cdac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

GrosSacASac · 2020-01-28T16:51:04Z

Many questions but I don't know, I am glad you stepped in again.

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

tunnckoCore · 2020-01-28T16:56:40Z

Anyway, I just ignored the problems. Will merge it and continue with other stuff - maybe switch to Jest, at least, seems easy ;d.

lgtm-com · 2020-01-28T17:00:13Z

This pull request introduces 1 alert and fixes 1 when merging 1bef152 into a26cdac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

lgtm-com · 2020-01-28T17:07:11Z

This pull request introduces 1 alert and fixes 1 when merging c1911af into a26cdac - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

tunnckoCore · 2020-01-28T22:30:19Z

Seems like the problem is that it doesn't emit field and always creates files, even when type="text" name="simple"

as mentioned here #531 (comment) Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

tunnckoCore · 2020-01-29T15:09:33Z

@all-contributors please add @GrosSacASac for code, doc, bug, maintenance and financial

allcontributors · 2020-01-29T15:09:41Z

@tunnckoCore

I've put up a pull request to add @GrosSacASac! 🎉

tunnckoCore · 2020-01-29T16:31:12Z

@all-contributors please add @GrosSacASac for the Streams API idea & upgrade

allcontributors · 2020-01-29T16:31:20Z

@tunnckoCore

I've put up a pull request to add @GrosSacASac! 🎉

tunnckoCore · 2020-01-29T16:37:15Z

@all-contributors please add @GrosSacASac for code, bug, maintenance, financial and review

allcontributors · 2020-01-29T16:37:23Z

@tunnckoCore

I've put up a pull request to add @GrosSacASac! 🎉

GrosSacASac added 5 commits December 4, 2019 23:57

start with streams

7eeb7d9

fix JSON decoder

8634386

save

9010a17

Merge branch 'master' into streams

868a4e3

Update multipart_parser.js

daebbde

This comment has been minimized.

Sign in to view

tunnckoCore mentioned this pull request Dec 11, 2019

Frustrating warnings when used with webpack #337

Closed

use streams API in the multipart example

2f9191d

use sreaing api

214708a

end does not return errors, use 'error' event instead write does not return length anymore

use the new multipartparser which is a stream

b688b66

revert, add todo

308dfa0

GrosSacASac added 3 commits December 18, 2019 18:49

emit error via recommended stream way

a3fe96b

octet parser is passtrough

63ec105

querystringparser is a stream

c4f8d7b

Update incoming_form.js

dd4a9d5

Dummy parser is a stream

bf10f2f

GrosSacASac added 2 commits December 22, 2019 01:24

formatting

e9f226d

listen for errors earlier

3f392e1

decouple, don't self check internals

40b830e

chore: comment failing test, fix ti soon

3d0b96d

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

chore: make tests passing; ignore workarounds fixture

0bd03a1

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

tunnckoCore added 2 commits January 28, 2020 18:53

chore: proper ignore; use tap reporter;

8c168e6

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

chore: some formatting happens...

1bef152

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

chore: add to changelog

c1911af

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

tunnckoCore changed the title ~~Streams~~ feat: use modern Streams API Jan 28, 2020

tunnckoCore merged commit 19c252a into master Jan 28, 2020

tunnckoCore deleted the streams branch January 28, 2020 17:03

tunnckoCore added a commit that referenced this pull request Jan 28, 2020

fix: handle (& part) files and fields correctly

621e72a

as mentioned here #531 (comment) Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

node-formidable deleted a comment from allcontributors Bot Jan 29, 2020

allcontributors Bot mentioned this pull request Jan 29, 2020

docs: add GrosSacASac as a contributor #548

Merged

allcontributors Bot mentioned this pull request Jan 29, 2020

docs: add GrosSacASac as a contributor #554

Merged

allcontributors Bot mentioned this pull request Jan 29, 2020

docs: add GrosSacASac as a contributor #555

Merged

tunnckoCore mentioned this pull request Jan 29, 2020

Part has no pause method #296

Closed

This was referenced Feb 6, 2020

[v1.x] bad content-type: application/javascript - cannot handle the error #571

Closed

RFC: Convert to monorepo & meta stuff (tidelift) #569

Closed

Uh oh!

Uh oh!

Conversation

GrosSacASac commented Dec 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

lgtm-com Bot commented Dec 17, 2019

Uh oh!

lgtm-com Bot commented Dec 17, 2019

Uh oh!

lgtm-com Bot commented Dec 17, 2019

Uh oh!

lgtm-com Bot commented Dec 17, 2019

Uh oh!

GrosSacASac commented Dec 18, 2019

Uh oh!

lgtm-com Bot commented Dec 18, 2019

Uh oh!

lgtm-com Bot commented Dec 18, 2019

Uh oh!

lgtm-com Bot commented Dec 21, 2019

Uh oh!

lgtm-com Bot commented Dec 22, 2019

Uh oh!

lgtm-com Bot commented Dec 26, 2019

Uh oh!

lgtm-com Bot commented Dec 26, 2019

Uh oh!

tunnckoCore commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com Bot commented Jan 28, 2020

Uh oh!

lgtm-com Bot commented Jan 28, 2020

Uh oh!

GrosSacASac commented Jan 28, 2020

Uh oh!

tunnckoCore commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com Bot commented Jan 28, 2020

Uh oh!

lgtm-com Bot commented Jan 28, 2020

Uh oh!

tunnckoCore commented Jan 28, 2020

Uh oh!

tunnckoCore commented Jan 29, 2020

Uh oh!

allcontributors Bot commented Jan 29, 2020

Uh oh!

tunnckoCore commented Jan 29, 2020

Uh oh!

allcontributors Bot commented Jan 29, 2020

Uh oh!

tunnckoCore commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allcontributors Bot commented Jan 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GrosSacASac commented Dec 9, 2019 •

edited

Loading

tunnckoCore commented Jan 28, 2020 •

edited

Loading

tunnckoCore commented Jan 28, 2020 •

edited

Loading

tunnckoCore commented Jan 29, 2020 •

edited

Loading